-
-
Notifications
You must be signed in to change notification settings - Fork 88
feat: Add support for option baseUrl set to async function
#285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for option baseUrl set to async function
#285
Conversation
|
🚀 Thanks for opening this pull request! |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe changes update documentation to clarify accepted types for the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant S3Adapter
participant buildDirectAccessUrl
participant baseUrlFunction
Caller->>S3Adapter: getFileLocation(config, filename)
S3Adapter->>buildDirectAccessUrl: await buildDirectAccessUrl(baseUrl, ...)
alt baseUrl is async function
buildDirectAccessUrl->>baseUrlFunction: await baseUrl(config, filename)
baseUrlFunction-->>buildDirectAccessUrl: urlBase (Promise resolved)
else baseUrl is string or sync function
buildDirectAccessUrl->>buildDirectAccessUrl: urlBase (direct)
end
buildDirectAccessUrl-->>S3Adapter: directAccessUrl
S3Adapter-->>Caller: fileLocation (URL)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 97.18% 97.19% +0.01%
==========================================
Files 2 2
Lines 213 214 +1
==========================================
+ Hits 207 208 +1
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# [4.2.0](4.1.1...4.2.0) (2025-06-12) ### Features * Add support for option `baseUrl` set to async function ([#285](#285)) ([6eae9e1](6eae9e1))
|
🎉 This change has been released in version 4.2.0 |
Summary by CodeRabbit
Documentation
New Features
Tests